When binding roles, the user list is changed to the drop-down selection mode （在绑定角色的时候用户列表改成下拉选中的模式) #3518 #3522
Conversation
…the same as the configuration management page #3500
ZZQ001010
changed the title
|
Please use nacos code style to reformat your change of java code |
| @@ -39,13 +40,13 @@ | |||
| @Conditional(value = ConditionOnEmbeddedStorage.class) | |||
| @Component | |||
| public class EmbeddedUserPersistServiceImpl implements UserPersistService { | |||
|
|
|||
There was a problem hiding this comment.
Do not change indent please.
please check for all your changed files
There was a problem hiding this comment.
Github show the indent still be changed
| @@ -39,13 +40,13 @@ | |||
| @Conditional(value = ConditionOnEmbeddedStorage.class) | |||
| @Component | |||
| public class EmbeddedUserPersistServiceImpl implements UserPersistService { | |||
|
|
|||
There was a problem hiding this comment.
Github show the indent still be changed
# Conflicts: # console/src/main/resources/static/js/main.js
|
@ready to close@ |
|
|
||
| @Override | ||
| public List<User> findUserLikeUsername(String username) { | ||
| String sql = "SELECT username FROM users WHERE username like '%' ? '%'"; |
There was a problem hiding this comment.
Is the SQL is right? Can you make sure this SQL can run both in derby and mysql?
There was a problem hiding this comment.
I think the SQL will be handle to SELECT username FROM users WHERE username like '%' 'xxx' '%'; if username is xxx
|
|
||
| @Override | ||
| public List<User> findUserLikeUsername(String username) { | ||
| String sql = "SELECT username,password FROM users WHERE username like '%' ? '%'"; |
There was a problem hiding this comment.
Only query username in Embedded, but username,password in Extranal?
|
@KomachiSion Don't close this ,I will optimize similar functions in other places tomorrow |
One PR one change, If you want to do some change about other feature, please open new PR. |
KomachiSion
added
area/Nacos console
在绑定角色的时候用户列表改成下拉选中的模式 #3518